Fix constant names and typos in aioble examples and deepcopy function #1058
Conversation
closes: micropython#1055 Signed-off-by: Jos Verlinde <Jos_Verlinde@hotmail.com>
closes: micropython#699 Signed-off-by: Jos Verlinde <Jos_Verlinde@hotmail.com>
closes: micropython#952 Signed-off-by: Jos Verlinde <Jos_Verlinde@hotmail.com>
This is a working alternative to PR micropython#919 closes: micropython#919 Signed-off-by: Jos Verlinde <Jos_Verlinde@hotmail.com>
dpgeorge
left a comment
dpgeorge
left a comment
There was a problem hiding this comment.
Thanks for this, there are some good fixes here.
I approve all commits except the RST formatting one.
| THE SOFTWARE. | ||
| Basic example usage: | ||
| Basic example usage:: |
There was a problem hiding this comment.
I'm not against this indenting change, but doe we need to make it RST compatible with the double colon?
I'm curious why you made the change / how you found these problems? It's not really supposed to be RST format.
There was a problem hiding this comment.
Reverted the RST :: and `` in this and other files.
python-stdlib/cmd/cmd.py
Outdated
| 1. End of file on input is processed as the command 'EOF'. | ||
| 2. A command is parsed out of each line by collecting the prefix composed | ||
| 2. A command is parsed out of each line by collecting the prefix composed |
There was a problem hiding this comment.
I don't think it should add a space at the end of the line.
python-stdlib/cmd/cmd.py
Outdated
| ---------------------------------------------------------------------------- | ||
| This is a copy of python's Cmd, but leaves out features that aren't relevant | ||
| or can't currently be implemented for MicroPython. | ||
| .. caution:: |
There was a problem hiding this comment.
I really don't think we should be using RST formatting here.
python-stdlib/heapq/heapq.py
Outdated
| heapify(x) # transforms list into a heap, in-place, in linear time | ||
| item = heapreplace(heap, item) # pops and returns smallest item, and adds | ||
| # new item; the heap size is unchanged | ||
| heap = [] # creates an empty heap |
There was a problem hiding this comment.
Why not 4 space indent like the other example code reformatted in this PR?
There was a problem hiding this comment.
thanks, missed that
|
The rst formatting was a side effect of the work I started with @jimmo to see if/how it would be possible to generate documentation pages from the source files. I have reverted the RST formatting to plaintext.
|
Bumped patch level in manifest for each changed module Signed-off-by: Jos Verlinde <Jos_Verlinde@hotmail.com>
2 participants
This PR combines a few rather minor fixes of typos in documentation and scripts.
Fixes #1055, #699, #952